Skip to content

fix(route53): avoid setting unnecessary properties for Recovery Control type Route53 health check #34272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 21, 2025
Merged

fix(route53): avoid setting unnecessary properties for Recovery Control type Route53 health check #34272

merged 5 commits into from
May 21, 2025
+20,045 −21,369

Conversation

msysh
Copy link
Contributor

@msysh msysh commented Apr 27, 2025

Issue # (if applicable)

Closes #34262

Reason for this change

Unnecessary properties are set for Route53 health checks for Recovery Control type.

Description of changes

If HealthCheck type is Recovery Control, return undefined as default value for three properties (FailureThreshold, RequestInterval, and MeasureLatency).

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Used Match.absent() to validate that the above three properties are not explicitly specified in existing unit tests. And added test cases to the integration tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Apr 27, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 27, 2025 07:37
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels Apr 27, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Apr 27, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@msysh msysh changed the title fix(aws-route53): Avoid setting unnecessary properties for Recovery Control type Route53 health check fix(route53): avoid setting unnecessary properties for Recovery Control type Route53 health check Apr 27, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 27, 2025 07:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 27, 2025
@github-actions github-actions bot mentioned this pull request May 1, 2025
Open
@aemada-aws aemada-aws self-assigned this May 21, 2025
@paulhcsun
Copy link
Contributor

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented May 21, 2025

update

✅ Branch has been successfully updated

@mergify Mergify
Copy link
Contributor

mergify bot commented May 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 21, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented May 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6bc01c9 into aws:main May 21, 2025
16 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented May 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 851eda8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions GitHub Actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aemada-aws aemada-aws aemada-aws approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@aemada-aws aemada-aws

Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-route53): cannot create HealthCheck with recovery control type
4 participants
@msysh @paulhcsun @aws-cdk-automation @aemada-aws